-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Router contract #37
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lib adds solmate lib that is used in ERC4626 contracts.
Only some of the contracts were copied and pasted just for Acre needs. In Acre project we use HH with yarn manager and this is why the path to solmate's library in node_modules had to be changed. Added only `/src` to the path. The rest of the code was unchanged and is based on 643cd04 commit from the following repo: https://github.com/ERC4626-Alliance/ERC4626-Contracts
We will have a set of Allocator conract addresses. Only Acre manager can add or remove an allocator address. Only owner can add a manager. Added `allocate` and `collect` function placeholder for further development.
Define pre-commit hooks for core package. Co-authored-by: Rafal Czajkowski <[email protected]>
Co-authored-by: Rafal Czajkowski <[email protected]>
When configuring the hooks we may want to test them before pushing.
This is an initial implementation of the CI process to check formatting in `website` workspace. Co-authored-by: Rafal Czajkowski <[email protected]>
This is an initial implementation of the CI process to check formatting in `dapp` workspace.
This was referenced Nov 27, 2023
Closing this PR and continue work in #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Based on the following System Design: